Skip to content

fix(core): tray not closing on Windows#3351

Merged
lucasfernog merged 2 commits into
nextfrom
fix/tray-remove
Feb 7, 2022
Merged

fix(core): tray not closing on Windows#3351
lucasfernog merged 2 commits into
nextfrom
fix/tray-remove

Conversation

@lucasfernog

Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team as a code owner February 7, 2022 13:15
@lucasfernog lucasfernog requested a review from a team February 7, 2022 13:15
@lucasfernog lucasfernog merged commit a03b855 into next Feb 7, 2022
@lucasfernog lucasfernog deleted the fix/tray-remove branch February 7, 2022 16:04
@amrbashir

Copy link
Copy Markdown
Member

why did you need to reimplement this? dropping tao::system_tray::SystemTray() instance will automatically clean the icon from the Windows system tray. If not, this should be considered a regression in tao and needs to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants