Skip to content

once_global and once accept FnOnce callbacks#3383

Merged
lucasfernog merged 4 commits into
nextfrom
fix/fnonce
Feb 10, 2022
Merged

once_global and once accept FnOnce callbacks#3383
lucasfernog merged 4 commits into
nextfrom
fix/fnonce

Conversation

@JonasKruckenberg
Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

I had to use Cell to get the interior mutability to work, if you guys have a better idea let me know.

@JonasKruckenberg JonasKruckenberg requested a review from a team February 10, 2022 09:10
@JonasKruckenberg JonasKruckenberg requested a review from a team as a code owner February 10, 2022 09:10
@JonasKruckenberg JonasKruckenberg changed the title Fix/fnonce once_global and once accept FnOnce callbacks Feb 10, 2022
@lucasfernog lucasfernog merged commit d5400a3 into next Feb 10, 2022
@lucasfernog lucasfernog deleted the fix/fnonce branch February 10, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants