Skip to content

fix(cta): fix cli install with other deps, fixes #3417 - #3420

Merged
amrbashir merged 2 commits into
devfrom
fix/cta/cli-installation
Feb 12, 2022
Merged

fix(cta): fix cli install with other deps, fixes #3417#3420
amrbashir merged 2 commits into
devfrom
fix/cta/cli-installation

Conversation

@amrbashir

Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir
amrbashir requested a review from a team as a code owner February 12, 2022 08:30
@amrbashir
amrbashir requested a review from FabianLars February 12, 2022 08:31
@amrbashir

Copy link
Copy Markdown
Member Author

@FabianLars I need your help again to test this, thanks.

FabianLars
FabianLars previously approved these changes Feb 12, 2022
@FabianLars

Copy link
Copy Markdown
Member

Tested CRA and vite recipes with and without @tauri-apps/api.

@amrbashir

Copy link
Copy Markdown
Member Author

Nice, thanks.

@amrbashir
amrbashir merged commit c010360 into dev Feb 12, 2022
@amrbashir
amrbashir deleted the fix/cta/cli-installation branch February 12, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants