Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli.rs): allow passing arguments to the build runner, closes #3398 #3431

Merged
merged 4 commits into from
Feb 13, 2022

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team February 13, 2022 04:16
@lucasfernog lucasfernog requested a review from a team as a code owner February 13, 2022 04:16
@amrbashir
Copy link
Member

What about tauri dev? I think the author of the issue wanted that.

@lucasfernog
Copy link
Member Author

lucasfernog commented Feb 13, 2022

What about tauri dev? I think the author of the issue wanted that.

Tauri dev is tricky because we're already using the -- <ARGS> approach to pass commands to the binary. So maybe we change dev to work the same way as build, which already comes with support to passing args to the binary (tauri dev -- --frozen -- --arg-to-binary. Ugly but it works.

@amrbashir
Copy link
Member

amrbashir commented Feb 13, 2022

yeah, I hardly think anyone uses it but so we don't introduce any breaking change we could do something like this
tauri build/dev --cargo-args="-vvv -Z unstable-options"

the name could be better

@amrbashir
Copy link
Member

So maybe we change dev to work the same way as build, which already comes with support to passing args to the binary (tauri dev -- --frozen -- --arg-to-binary. Ugly but it works.

or that

@lucasfernog
Copy link
Member Author

I went with a small breaking change, now is the time anyway. Keeping the syntax the same is more important IMO.

amrbashir
amrbashir previously approved these changes Feb 13, 2022
.changes/refactor-cli-dev-args.md Outdated Show resolved Hide resolved
[skip ci]

Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants