Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop Sync req from setup and setup_with_config #3471

Merged
merged 3 commits into from
Feb 16, 2022

Conversation

JonasKruckenberg
Copy link
Contributor

@JonasKruckenberg JonasKruckenberg commented Feb 15, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Somehow this got lost during the previous PR. There is really no reason for SetupHook and SetupWithConfigHook.

  1. The function gets called during App::plugin on the same Thread.
  2. Even if we call it from a different thread, if the closure consumes owned references, those will not live past that closure and can't be shared between threads anyway. So the Sync requirement is redundant if I'm correct.

@JonasKruckenberg JonasKruckenberg requested a review from a team February 15, 2022 18:29
@JonasKruckenberg JonasKruckenberg requested a review from a team as a code owner February 15, 2022 18:32
@lucasfernog lucasfernog merged commit fb7ee2c into dev Feb 16, 2022
@lucasfernog lucasfernog deleted the JonasKruckenberg-patch-1 branch February 16, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants