Skip to content

fix(bundler): sidecar on Windows, closes #3446#3482

Merged
lucasfernog merged 1 commit into
devfrom
fix/sidecar-bundling-windows
Feb 17, 2022
Merged

fix(bundler): sidecar on Windows, closes #3446#3482
lucasfernog merged 1 commit into
devfrom
fix/sidecar-bundling-windows

Conversation

@lucasfernog

Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

This is an extension of the #3356 work, we forgot to update the WiX bundler as it doesn't use the copy_binaries function.

@lucasfernog lucasfernog requested review from a team February 16, 2022 15:01
@lucasfernog lucasfernog requested a review from a team as a code owner February 16, 2022 15:01
@lucasfernog lucasfernog merged commit 2ecbed8 into dev Feb 17, 2022
@lucasfernog lucasfernog deleted the fix/sidecar-bundling-windows branch February 17, 2022 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant