fix: read Command output ending with a carriage return, closes #3508#3523
Merged
lucasfernog merged 5 commits intodevfrom Feb 24, 2022
Merged
fix: read Command output ending with a carriage return, closes #3508#3523lucasfernog merged 5 commits intodevfrom
lucasfernog merged 5 commits intodevfrom
Conversation
chippers
requested changes
Feb 24, 2022
Member
chippers
left a comment
There was a problem hiding this comment.
This looks ok to me in general. Ideally we wrap the PipeReader stuff inside a function so we can reuse the logic exactly for stdout/stderr.
The only required change that is requested is the unwrap() one, or an explanation of it added to the code in a comment.
As far as logic goes, I don't see anything wrong. There's more room for optimization with memchr (I think), but I really don't see the point if this isn't proven to be a bottleneck. It can always be done later since this approach doesn't really lock anything into public api
Co-authored-by: chip <chip@chip.sh>
…rn' into fix/command-stdout-carriage-return
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
The
process::CommandAPI will now read lines until a\nor a\ris found.