Skip to content

fix: read Command output ending with a carriage return, closes #3508#3523

Merged
lucasfernog merged 5 commits intodevfrom
fix/command-stdout-carriage-return
Feb 24, 2022
Merged

fix: read Command output ending with a carriage return, closes #3508#3523
lucasfernog merged 5 commits intodevfrom
fix/command-stdout-carriage-return

Conversation

@lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

The process::Command API will now read lines until a \n or a \r is found.

@lucasfernog lucasfernog requested a review from a team February 20, 2022 20:26
@lucasfernog lucasfernog requested a review from a team as a code owner February 20, 2022 20:26
Copy link
Member

@chippers chippers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok to me in general. Ideally we wrap the PipeReader stuff inside a function so we can reuse the logic exactly for stdout/stderr.

The only required change that is requested is the unwrap() one, or an explanation of it added to the code in a comment.

As far as logic goes, I don't see anything wrong. There's more room for optimization with memchr (I think), but I really don't see the point if this isn't proven to be a bottleneck. It can always be done later since this approach doesn't really lock anything into public api

@lucasfernog lucasfernog requested a review from chippers February 24, 2022 13:55
@lucasfernog lucasfernog merged commit 0a0de8a into dev Feb 24, 2022
@lucasfernog lucasfernog deleted the fix/command-stdout-carriage-return branch February 24, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants