fix(core): docs.rs on Windows and macOS#3566
Merged
lucasfernog merged 15 commits intotauri-apps:devfrom Mar 2, 2022
Merged
Conversation
chippers
requested changes
Mar 1, 2022
Member
There was a problem hiding this comment.
I don't mind the __isolation-docs workaround if ring itself if causing cargo doc to fail. We just will want to make sure that is what causes it. The suggested change makes it a single compile-time error if it is somehow used without enabling the isolation feature or the isolation docs workaround, along with making using it with only the docs workaround a runtime error since it's not secure.
Member
Author
|
I tested the doc generation directly using the docs.rs repo and ring was one of the issues, so i had to disable it. |
Co-authored-by: chip <chip@chip.sh>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information