Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for Time-Stamping Protocol for Windows codesigning (fix #3563) #3570

Merged
merged 9 commits into from
Mar 7, 2022

Conversation

gardc
Copy link
Contributor

@gardc gardc commented Feb 28, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

First time contributing code to Tauri, so please feel free to let me know if there are any issues or something that could be improved.

@gardc gardc requested review from a team February 28, 2022 07:33
@gardc gardc requested a review from a team as a code owner February 28, 2022 07:33
@chippers
Copy link
Member

chippers commented Mar 1, 2022

can you run cargo +nightly fmt on your branch so that we avoid formatting changes? it would also make it easier to review

@gardc
Copy link
Contributor Author

gardc commented Mar 1, 2022

@chippers cargo +nightly fmt wasn't working properly for me, but I fixed the formatting in sign.rs which got changed for some reason.

.changes/bundler-add-tsp-signing.md Outdated Show resolved Hide resolved
.changes/bundler-add-tsp-signing.md Outdated Show resolved Hide resolved
@lucasfernog lucasfernog merged commit bdd5f7c into tauri-apps:dev Mar 7, 2022
@lucasfernog
Copy link
Member

Thank you ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants