Skip to content

refactor(core): move png and ico behind Cargo features#3588

Merged
lucasfernog merged 15 commits intotauri-apps:devfrom
lucasfernog:refactor/icons
Mar 5, 2022
Merged

refactor(core): move png and ico behind Cargo features#3588
lucasfernog merged 15 commits intotauri-apps:devfrom
lucasfernog:refactor/icons

Conversation

@lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

This improves performance at runtime and produces a smaller binary if you don't need to change the window icon at runtime.

@lucasfernog lucasfernog requested review from a team March 2, 2022 15:15
@lucasfernog lucasfernog requested a review from a team as a code owner March 2, 2022 15:15
@lucasfernog lucasfernog merged commit 8c93587 into tauri-apps:dev Mar 5, 2022
@lucasfernog lucasfernog deleted the refactor/icons branch March 5, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant