Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add WindowEvent::FileDrop, closes #3664 #3686

Merged
merged 3 commits into from
Mar 13, 2022

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team March 12, 2022 12:44
@lucasfernog lucasfernog requested a review from a team as a code owner March 12, 2022 12:44
@FabianLars
Copy link
Member

With that change we could theoretically remove the tauri:// events from rust again right? They are not reallyyy usable anyway (and afaik pretty much nobody uses them either) 🤷

Of course we still need the updater events.

@lucasfernog
Copy link
Member Author

lucasfernog commented Mar 12, 2022

Well we can also offer the updater events as part of the App::run callback. I think we'll rely on it more for v2.

@lucasfernog
Copy link
Member Author

@FabianLars #3687 crazy change but at least no one has to deal with the magic string event payloads on the Rust side.

@lucasfernog lucasfernog merged commit 07d1584 into dev Mar 13, 2022
@lucasfernog lucasfernog deleted the feat/file-drop-event-rs branch March 13, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants