Skip to content

refactor(core): use the event loop proxy to send updater events#3687

Merged
lucasfernog merged 5 commits intodevfrom
refactor/updater-events
Mar 15, 2022
Merged

refactor(core): use the event loop proxy to send updater events#3687
lucasfernog merged 5 commits intodevfrom
refactor/updater-events

Conversation

@lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team March 12, 2022 18:22
@lucasfernog lucasfernog requested a review from a team as a code owner March 12, 2022 18:22
@FabianLars
Copy link
Member

Oh wow, that escalated 😅 But i love the change(s).

Base automatically changed from feat/file-drop-event-rs to dev March 13, 2022 14:28
@lucasfernog
Copy link
Member Author

We could extend this work to allow an user event type and expose the proxy, but it's a massive breaking change (adding an extra generic type on everything that references R: Runtime (I started doing it and it is possible).

@lucasfernog lucasfernog merged commit 5d538ec into dev Mar 15, 2022
@lucasfernog lucasfernog deleted the refactor/updater-events branch March 15, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants