Support window parenting on macOS, closes #3751#3754
Merged
lucasfernog merged 9 commits intodevfrom Mar 23, 2022
Merged
Conversation
vdvman1
reviewed
Mar 22, 2022
Member
Author
|
The example is failing because the Windows |
Member
|
@probablykasper I think the best solution is to change |
Member
Author
|
Hm, no clue why that would be. Any idea if it works in tao atm? |
amrbashir
requested changes
Mar 23, 2022
[skip ci] Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
Member
|
Parent window directly on tao is weird but at least it shows the child window. I think wry is touching the window and messing with it too. Do you know if that's the case @amrbashir |
lucasfernog
approved these changes
Mar 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
Closes #3751
Usage:
Implemented it in the same way as for Windows, but it would be nice if usage was the same for all platforms. Not sure what the way to implement that would be, maybe
RawWindowHandle? Would also be a breaking change, unless a different name is used.