-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support window parenting on macOS, closes #3751 #3754
Conversation
The example is failing because the Windows |
@probablykasper I think the best solution is to change |
Hm, no clue why that would be. Any idea if it works in tao atm? |
[skip ci] Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
Parent window directly on tao is weird but at least it shows the child window. I think wry is touching the window and messing with it too. Do you know if that's the case @amrbashir |
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information
Closes #3751
Usage:
Implemented it in the same way as for Windows, but it would be nice if usage was the same for all platforms. Not sure what the way to implement that would be, maybe
RawWindowHandle
? Would also be a breaking change, unless a different name is used.