Skip to content

feat(core): add dangerous option to disable compile time CSP injection#3775

Merged
lucasfernog merged 5 commits intodevfrom
feat/dangerous-disable-csp
Mar 28, 2022
Merged

feat(core): add dangerous option to disable compile time CSP injection#3775
lucasfernog merged 5 commits intodevfrom
feat/dangerous-disable-csp

Conversation

@lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team March 25, 2022 13:28
@lucasfernog lucasfernog requested a review from a team as a code owner March 25, 2022 13:28
@JonasKruckenberg
Copy link
Member

I think the naming could be improved here, disable_asset_csp makes it sound as if it would disable the whole csp mechanism. I have no idea for better names either though

@lucasfernog lucasfernog requested a review from a team March 28, 2022 00:20
@lucasfernog
Copy link
Member Author

Is dangerous_disable_asset_csp_injection better? @JonasKruckenberg this is so hard 😂

@lucasfernog
Copy link
Member Author

I guess dangerous_disable_asset_csp_modification is the least ambiguous choice.

@JonasKruckenberg
Copy link
Member

I mean it's a mouthful 😅 but it's the best name yet so let's go 👍🏻

@lucasfernog
Copy link
Member Author

It's supposed to be. It's a dangerous config, we need to do our best to discourage people to even write it, and if they do, force them to make typos to regret enabling it 😂 😂

@lucasfernog lucasfernog merged commit f6e32ee into dev Mar 28, 2022
@lucasfernog lucasfernog deleted the feat/dangerous-disable-csp branch March 28, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants