Skip to content

fix(tauri): export WindowBuilder struct instead of trait, closes #3827#3833

Merged
lucasfernog merged 3 commits into
devfrom
fix/window-builder
Mar 31, 2022
Merged

fix(tauri): export WindowBuilder struct instead of trait, closes #3827#3833
lucasfernog merged 3 commits into
devfrom
fix/window-builder

Conversation

@lucasfernog

Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

The trait won't be needed on the next release, we will drop the create_new_window APIs.

@lucasfernog
lucasfernog requested a review from a team March 31, 2022 16:42
@lucasfernog
lucasfernog requested a review from a team as a code owner March 31, 2022 16:42
@lucasfernog
lucasfernog requested a review from a team March 31, 2022 16:48
@lucasfernog

Copy link
Copy Markdown
Member Author

Tests will be fixed on #3834

@lucasfernog
lucasfernog merged commit 985d250 into dev Mar 31, 2022
@lucasfernog
lucasfernog deleted the fix/window-builder branch March 31, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant