Skip to content

refactor: drop strip from build command. closes #3559#3863

Merged
lucasfernog merged 2 commits intodevfrom
drop-strip
Apr 6, 2022
Merged

refactor: drop strip from build command. closes #3559#3863
lucasfernog merged 2 commits intodevfrom
drop-strip

Conversation

@JonasKruckenberg
Copy link
Member

@JonasKruckenberg JonasKruckenberg commented Apr 6, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@JonasKruckenberg JonasKruckenberg requested a review from a team April 6, 2022 08:55
@JonasKruckenberg JonasKruckenberg requested a review from a team as a code owner April 6, 2022 08:55
@JonasKruckenberg JonasKruckenberg changed the title refactor: drop strip from build command. refactor: drop strip from build command. closes #3559 Apr 6, 2022
@lucasfernog lucasfernog merged commit 6210622 into dev Apr 6, 2022
@lucasfernog lucasfernog deleted the drop-strip branch April 6, 2022 12:45
@FabianLars FabianLars mentioned this pull request Jun 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JonasKruckenberg @lucasfernog