Skip to content

fix(bundler): set app name when signing MSI, closes #3945#3950

Merged
lucasfernog merged 1 commit into
devfrom
fix/windows-sign-app-name
May 17, 2022
Merged

fix(bundler): set app name when signing MSI, closes #3945#3950
lucasfernog merged 1 commit into
devfrom
fix/windows-sign-app-name

Conversation

@lucasfernog
Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team April 23, 2022 13:57
@lucasfernog lucasfernog requested a review from a team as a code owner April 23, 2022 13:57
@lucasfernog
Copy link
Copy Markdown
Member Author

Unfortunately I can't test this until next week as I don't have a cert right now.

@lucasfernog
Copy link
Copy Markdown
Member Author

Works like a charm!

@lucasfernog lucasfernog merged commit 8e1daad into dev May 17, 2022
@lucasfernog lucasfernog deleted the fix/windows-sign-app-name branch May 17, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant