Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): add global-shortcut Cargo feature, enhancing binary size #3956

Merged
merged 3 commits into from
Apr 24, 2022

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Improve the binary size by moving the global shortcut APIs behind a Cargo feature flag. This enhances the binary size by 17-90KB when the feature is not enabled, depending of the platform.

@lucasfernog lucasfernog requested a review from a team April 24, 2022 17:20
@lucasfernog lucasfernog requested a review from a team as a code owner April 24, 2022 17:20
@lucasfernog lucasfernog changed the title perf(core): improve binary size with api enum serde refactor (#3952) refactor(core): add global-shortcut Cargo feature, enhancing binary size Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant