feat(cli): check and notify about updates on tauri dev, closes #3789#3960
feat(cli): check and notify about updates on tauri dev, closes #3789#3960lucasfernog merged 4 commits intotauri-apps:devfrom
tauri dev, closes #3789#3960Conversation
this feature helps the users of tauri know that there is a new version of CLI avaliable. it uses `metadata.json` from the tooling/cli directory (raw asset from github) and checks with the bundled version of metadata.json.
| Ok((msg, sleep)) => { | ||
| if sleep { | ||
| logger.log(msg); | ||
| std::thread::sleep(std::time::Duration::from_secs(3)); |
There was a problem hiding this comment.
Why 3 secs sleep when there is a new version available?
There was a problem hiding this comment.
@amrbashir it is to make user aware of the update, if we don't sleep at that time next command might clear the terminal buffer and user might miss it completely or not care about it.
There was a problem hiding this comment.
but that delay is bad for UX IMO. Like I'd want the dev process to start as soon as possible.
There was a problem hiding this comment.
what can be an alternative, may be ask for auto update (Y/n) instead?
There was a problem hiding this comment.
No, that also is a bad UX. I think we should just remove this delay. And if users don't see the notification, it is not that important.
Also note that after stable 2.0 release, users might deliberately choose to stay on 1.x for stability and we probably shouldn't annoy them because of that.
I honestly think we should remove this notification after 1.0 stable release is out because the CLI and other Tauri components will be stable by then and there will be no breaking changes moving forwards so you wouldn't need to update the CLI as often as the "beta" or "rc" phase.
…i-apps#3789 (tauri-apps#3960) Co-authored-by: Lucas Nogueira <lucas@tauri.studio>
3 participants
this feature helps the users of tauri know that there is a new version of CLI avaliable. it uses
metadata.jsonfrom the tooling/cli directory (raw asset from github) and checks with the bundled version of metadata.json.What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information