Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): dev command stderr text overflow on Windows, closes #3995 #4000

Merged
merged 2 commits into from
Apr 29, 2022

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Can you check this one @FabianLars ? I'm not sure because the issue isn't happening to me anymore, even without the change :|

@lucasfernog lucasfernog requested review from a team April 29, 2022 13:30
@lucasfernog lucasfernog requested a review from a team as a code owner April 29, 2022 13:30
@FabianLars
Copy link
Member

Nope, still the same

@lucasfernog
Copy link
Member Author

@FabianLars it should work now, though I fear it only hides the issue (probably in Cargo?) by limiting the progress bar to width 60.

@FabianLars
Copy link
Member

Yeah it works. It's looks kinda weird, because it doesn't have enough space to write the currently compiling crates, but i'd rather see this than this overflow mess 👍

@lucasfernog
Copy link
Member Author

Yeah unfortunately even 80 as width breaks it :/

@lucasfernog lucasfernog merged commit 094534d into dev Apr 29, 2022
@lucasfernog lucasfernog deleted the fix/cli-text-overflow branch April 29, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants