Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): powershell crashing on SIGINT, closes #3997 #4007

Merged
merged 3 commits into from
Apr 29, 2022

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team April 29, 2022 19:07
@lucasfernog lucasfernog requested a review from a team as a code owner April 29, 2022 19:07
Copy link
Member

@FabianLars FabianLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That fixed it 🥳

while testing it i discovered that npm still asks for confirmation, but without actually breaking anything (you can press ctrl-c or Y+enter to confirm like expected) and since the confirmation is standard on windows i'd leave it as-is (i wish there would be a setting to turn that off os-wide...)

@lucasfernog
Copy link
Member Author

Yeah I wish we could turn it off, but we can't. We could automatically send a Y to stdin, but we'd also need to detect the presence of the message and the language (yikes).

@lucasfernog lucasfernog changed the title fix(cli): powershell crashing on SIGINT,#3997 fix(cli): powershell crashing on SIGINT, closes #3997 Apr 29, 2022
@lucasfernog lucasfernog merged commit 3204848 into dev Apr 29, 2022
@lucasfernog lucasfernog deleted the fix/cli-ctrlc-powershell branch April 29, 2022 22:51
dceddia pushed a commit to dceddia/tauri that referenced this pull request May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants