Skip to content

fix(bundler): debian failing to load icns icon, closes #3062#4009

Merged
lucasfernog merged 2 commits intodevfrom
fix/debian-icns-load
Apr 30, 2022
Merged

fix(bundler): debian failing to load icns icon, closes #3062#4009
lucasfernog merged 2 commits intodevfrom
fix/debian-icns-load

Conversation

@lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team April 30, 2022 01:09
@lucasfernog lucasfernog requested a review from a team as a code owner April 30, 2022 01:09
@lucasfernog
Copy link
Member Author

It seems like the ICNS generation in tauricon is not producing a valid icon in the 16x16 type. Switching from png2icons to make-icns fixes the problem, but I still didn't check if it works on macOS. For now we can ignore an error in the bundler.

@lucasfernog lucasfernog merged commit de444b1 into dev Apr 30, 2022
@lucasfernog lucasfernog deleted the fix/debian-icns-load branch April 30, 2022 13:53
dceddia pushed a commit to dceddia/tauri that referenced this pull request May 14, 2022
tauri-apps#4009)

* fix(bundler): debian failing to load icns icon, closes tauri-apps#3062

* fix change file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant