Skip to content

fix(core): dialog crashing on macOS when the parent is empty#4028

Merged
lucasfernog merged 1 commit into
devfrom
fix/dialog-default-path-crash
May 3, 2022
Merged

fix(core): dialog crashing on macOS when the parent is empty#4028
lucasfernog merged 1 commit into
devfrom
fix/dialog-default-path-crash

Conversation

@lucasfernog
Copy link
Copy Markdown
Member

@lucasfernog lucasfernog commented May 2, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team May 2, 2022 15:55
@lucasfernog lucasfernog requested a review from a team as a code owner May 2, 2022 15:55
@lucasfernog lucasfernog merged commit d31167c into dev May 3, 2022
@lucasfernog lucasfernog deleted the fix/dialog-default-path-crash branch May 3, 2022 00:04
@gfrancine gfrancine mentioned this pull request May 3, 2022
Closed
@FabianLars FabianLars mentioned this pull request May 6, 2022
Closed
dceddia pushed a commit to dceddia/tauri that referenced this pull request May 14, 2022
@lucasfernog @dceddia
fix(core): dialog crashing on macOS when the parent is empty (tauri-a…
138b0eb 
…pps#4028)
amrbashir added a commit that referenced this pull request May 15, 2024
@amrbashir
fix(macos/dialog): avoid setting empty default_path
770ffda 
closes #7566

ref: #4065
ref: #4028
ref: #9762
@amrbashir amrbashir mentioned this pull request May 15, 2024
Merged
amrbashir added a commit that referenced this pull request May 15, 2024
@amrbashir
fix(macos/dialog): avoid setting empty default_path (#9784)
704260b 
closes #7566

ref: #4065
ref: #4028
ref: #9762
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lucasfernog