fix(build): append .exe binary based on target triple instead of running OS, closes #3870 #4032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We already have a function to get the current target triple :) awesome PR! |
|
Thanks a lot for all the fixes @lucasfernog ! |
|
Thanks for merging 🚀 |
dceddia
pushed a commit
to dceddia/tauri
that referenced
this pull request
May 14, 2022
…ing OS, closes tauri-apps#3870 (tauri-apps#4032) Co-authored-by: Lucas Nogueira <lucas@tauri.studio>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Yes, a minor one I hope:
cli::interface::rust::get_binaries()gets a newtarget: Option<String>argument, which is the target triple you want to build your application for.Checklist
fix: remove a typo, closes #___, #___)Other information
The side-effect of this is that it enables using cross as build runner to attempt cross-compiling projects.
Request for suggestions:
As the target is currently optional because it should fall back to the current target triple, I need some help knowing how to get the current target triple (in a cleaner way than what I currently found) so that we can no longer depend on an optional value.
I thought we could use these build-in constants ARCH, OS and FAMILY (from there: https://doc.rust-lang.org/std/env/consts/index.html ), but not sure of their reliability regarding Tauri's ecosystem.