Skip to content

fix(updater): remove single&double quotes escaping in updater dialog …#4047

Merged
lucasfernog merged 1 commit into
devfrom
fix/updater-dialog-body
May 4, 2022
Merged

fix(updater): remove single&double quotes escaping in updater dialog …#4047
lucasfernog merged 1 commit into
devfrom
fix/updater-dialog-body

Conversation

@amrbashir
Copy link
Copy Markdown
Member

…body, closes #4043

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team May 3, 2022 19:43
@amrbashir amrbashir requested a review from a team as a code owner May 3, 2022 19:43
@amrbashir
Copy link
Copy Markdown
Member Author

tested only on windows, linux and macos aren't

Copy link
Copy Markdown
Member

@lucasfernog lucasfernog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine on Linux and macOS too!

@lucasfernog lucasfernog merged commit 0180dcc into dev May 4, 2022
@lucasfernog lucasfernog deleted the fix/updater-dialog-body branch May 4, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] Single quotes are ignored in updater's release notes

2 participants