Skip to content

feat(tauri-runtime-wry): add plugin API#4094

Merged
lucasfernog merged 2 commits intodevfrom
feat/wry-plugin
May 10, 2022
Merged

feat(tauri-runtime-wry): add plugin API#4094
lucasfernog merged 2 commits intodevfrom
feat/wry-plugin

Conversation

@lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team May 10, 2022 11:54
@lucasfernog lucasfernog requested a review from a team as a code owner May 10, 2022 11:54
@JonasKruckenberg
Copy link
Member

JonasKruckenberg commented May 10, 2022

I think it'd make more sense to make this a callback on the Plugin trait instead of a completely separate thing wdyt?

You could call it on_wry_event or something 🤔

Edit: Or rather, we can have the TauriPlugin struct that is returned by the builder implement tauri_runtime_wry::Plugin too, that way we can just pass the whole plugin through to wry

@lucasfernog lucasfernog merged commit c8e0e5b into dev May 10, 2022
@lucasfernog lucasfernog deleted the feat/wry-plugin branch May 10, 2022 14:23
dceddia pushed a commit to dceddia/tauri that referenced this pull request May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants