Skip to content

fix(bundler): ignore duplicated files in resource iter, closes #4126#4129

Merged
lucasfernog merged 1 commit into
devfrom
fix/glob-resources-wix
May 15, 2022
Merged

fix(bundler): ignore duplicated files in resource iter, closes #4126#4129
lucasfernog merged 1 commit into
devfrom
fix/glob-resources-wix

Conversation

@lucasfernog
Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

The ResourcePaths iterator can list a file twice since it also reads a folder when the glob pattern finds it (via the walk_iter usage). This PR adds a guard in the wix bundler to prevent registering the file twice.

@lucasfernog lucasfernog requested a review from a team May 15, 2022 12:24
@lucasfernog lucasfernog requested a review from a team as a code owner May 15, 2022 12:24
@lucasfernog lucasfernog merged commit 3e702cf into dev May 15, 2022
@lucasfernog lucasfernog deleted the fix/glob-resources-wix branch May 15, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant