Skip to content

fix: allow return value of fs::canonicalize on fs scope, closes #4130#4188

Merged
lucasfernog merged 1 commit into
devfrom
fix/windows-scope-check
May 21, 2022
Merged

fix: allow return value of fs::canonicalize on fs scope, closes #4130#4188
lucasfernog merged 1 commit into
devfrom
fix/windows-scope-check

Conversation

@lucasfernog
Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

I hope this fixes #4130 (at least it fixes usage with the dialog when reading files from the network).

@lucasfernog lucasfernog requested a review from a team May 21, 2022 19:37
@lucasfernog lucasfernog requested a review from a team as a code owner May 21, 2022 19:37
@lucasfernog lucasfernog merged commit 78f2565 into dev May 21, 2022
@lucasfernog lucasfernog deleted the fix/windows-scope-check branch May 21, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant