Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow return value of fs::canonicalize on fs scope, closes #4130 #4188

Merged
merged 1 commit into from
May 21, 2022

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

I hope this fixes #4130 (at least it fixes usage with the dialog when reading files from the network).

@lucasfernog lucasfernog requested a review from a team May 21, 2022 19:37
@lucasfernog lucasfernog requested a review from a team as a code owner May 21, 2022 19:37
@lucasfernog lucasfernog merged commit 78f2565 into dev May 21, 2022
@lucasfernog lucasfernog deleted the fix/windows-scope-check branch May 21, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] path not allowed on the configured scope (on windows)
1 participant