fix(cli): manual config lookup to handle gitignored folders, fixes #3527#4224
Merged
lucasfernog merged 1 commit intodevfrom May 26, 2022
Merged
fix(cli): manual config lookup to handle gitignored folders, fixes #3527#4224lucasfernog merged 1 commit intodevfrom
lucasfernog merged 1 commit intodevfrom
Conversation
lucasfernog
approved these changes
May 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
Turns out more people than expected have (parts of) their project gitignored and we currently only check if
$CWD/tauri.conf.jsonexists which doesn't work for the most common structure == the one you get via CTA/tauri init.The proposed workaround is really straightforward, we just manually check for
src-tauri/tauri.conf.jsonbefore starting the actual lookup.A nice-to-have side-effect is that this slightly improves performance for projects with the default structure 🤷