Skip to content

refactor(core): drop ayatana-tray and gtk-tray Cargo features#4247

Merged
lucasfernog merged 7 commits into
devfrom
refactor/tray-features
Jun 2, 2022
Merged

refactor(core): drop ayatana-tray and gtk-tray Cargo features#4247
lucasfernog merged 7 commits into
devfrom
refactor/tray-features

Conversation

@lucasfernog
Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested review from a team May 31, 2022 14:38
@lucasfernog lucasfernog requested a review from a team as a code owner May 31, 2022 14:38
@FabianLars
Copy link
Copy Markdown
Member

  • Since we're talking about .deb here (and therefore mainly about debian & ubuntu) we should probably use ayatana as the default.
  • iirc, we now depend on pkg-config at runtime, so we need to add that to the Depends field too right?

@lucasfernog
Copy link
Copy Markdown
Member Author

Yeah you're right, I'll make that change.

@lucasfernog lucasfernog merged commit 6216eb4 into dev Jun 2, 2022
@lucasfernog lucasfernog deleted the refactor/tray-features branch June 2, 2022 17:42
@lucasfernog
Copy link
Copy Markdown
Member Author

Ref #3859

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants