Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): drop ayatana-tray and gtk-tray Cargo features #4247

Merged
merged 7 commits into from
Jun 2, 2022

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested review from a team May 31, 2022 14:38
@lucasfernog lucasfernog requested a review from a team as a code owner May 31, 2022 14:38
@FabianLars
Copy link
Member

  • Since we're talking about .deb here (and therefore mainly about debian & ubuntu) we should probably use ayatana as the default.
  • iirc, we now depend on pkg-config at runtime, so we need to add that to the Depends field too right?

@lucasfernog
Copy link
Member Author

Yeah you're right, I'll make that change.

@lucasfernog lucasfernog merged commit 6216eb4 into dev Jun 2, 2022
@lucasfernog lucasfernog deleted the refactor/tray-features branch June 2, 2022 17:42
@lucasfernog
Copy link
Member Author

Ref #3859

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants