Fix: sidecar cleanup when only shell-sidecar is enabled#4254
Merged
lucasfernog merged 2 commits intotauri-apps:devfrom Jun 4, 2022
Merged
Fix: sidecar cleanup when only shell-sidecar is enabled#4254lucasfernog merged 2 commits intotauri-apps:devfrom
shell-sidecar is enabled#4254lucasfernog merged 2 commits intotauri-apps:devfrom
Conversation
Signed-off-by: Charlie Wilkin <charlie@busyboredom.com>
Contributor
Author
|
I didn't make an issue for this 'cause it's such a simple problem/solution, but if you need me to open an issue before this can be merged I will :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
Sidecar processes are not cleaned up properly unless
shell-executeis enabled. This is problematic for apps in which onlyshell-sidecaris needed.This fix calls
crate::api::process::kill_children()when eithershell-executeorshell-sidecarare enabled.