Skip to content

fix: put linux high dpi icons in the correct dir#4281

Merged
lucasfernog merged 2 commits intotauri-apps:devfrom
betamos:linux-icon-2x
Jun 10, 2022
Merged

fix: put linux high dpi icons in the correct dir#4281
lucasfernog merged 2 commits intotauri-apps:devfrom
betamos:linux-icon-2x

Conversation

@betamos
Copy link
Copy Markdown
Contributor

@betamos betamos commented Jun 6, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

It wasn't trivial to find a spec for this, but I think this is the right one: https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html

Note that we are not changing the source paths, "@2x" is still used for those, so this change is not user facing.

On ubuntu, `/usr/share/icons/hicolor` contains dir names that correspond to the new pattern. The previous "@2x" convention comes from Apple, and doesn't seem to apply to Linux.
@betamos betamos requested a review from a team June 6, 2022 02:22
Copy link
Copy Markdown
Member

@lucasfernog lucasfernog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a change file? :D

@betamos betamos requested a review from a team as a code owner June 9, 2022 20:01
@lucasfernog lucasfernog merged commit c2b7c77 into tauri-apps:dev Jun 10, 2022
@betamos betamos deleted the linux-icon-2x branch June 10, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants