Skip to content

feat(bundler): cache bundling tools in a common dir for all projects#4305

Merged
lucasfernog merged 14 commits intodevfrom
cache-bundle-tools
Jun 9, 2022
Merged

feat(bundler): cache bundling tools in a common dir for all projects#4305
lucasfernog merged 14 commits intodevfrom
cache-bundle-tools

Conversation

@amrbashir
Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team June 9, 2022 09:59
@amrbashir amrbashir requested a review from a team as a code owner June 9, 2022 09:59
@amrbashir
Copy link
Copy Markdown
Member Author

On Linux, I only changed the download path of linux-deploy and AppRun, I don't even know if the script was already caching them or downloads this files each tauri build

@amrbashir amrbashir requested review from a team June 9, 2022 13:34
@FabianLars
Copy link
Copy Markdown
Member

Does the removal of -nc mean that it will always overwrite existing files? Not familiar with wget, sry.

I'm asking because this was the main concern I had with this PR because the appimage tooling is unversioned and it would be kinda bad if users would end up not receiving bug fixes etc because of this.

@lucasfernog
Copy link
Copy Markdown
Member

Ahh I forgot we're shipping updates like that, I'll remove the -nc flag so it always downloads it.

@FabianLars
Copy link
Copy Markdown
Member

Ah lol you added the flag, gosh I can't read diffs in the GitHub mobile app 😂

This reverts commit 8d821c6.
@amrbashir
Copy link
Copy Markdown
Member Author

amrbashir commented Jun 9, 2022

maybe the -N flag is better to only download if newer ?

@lucasfernog
Copy link
Copy Markdown
Member

Ahh -N makes sense -N, --timestamping don't re-retrieve files unless newer than local

@lucasfernog lucasfernog merged commit f48b1b0 into dev Jun 9, 2022
@lucasfernog lucasfernog deleted the cache-bundle-tools branch June 9, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants