Skip to content

fix(cli): add shebang for kill-children.sh, closes #4262#4416

Merged
lucasfernog merged 2 commits intotauri-apps:devfrom
brian14708:fix-kill-children-script
Jun 21, 2022
Merged

fix(cli): add shebang for kill-children.sh, closes #4262#4416
lucasfernog merged 2 commits intotauri-apps:devfrom
brian14708:fix-kill-children-script

Conversation

@brian14708
Copy link
Contributor

@brian14708 brian14708 commented Jun 21, 2022

What kind of change does this PR introduce?

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@brian14708 brian14708 changed the title fix(cli): add shebang for kill-children.sh, closes #4262 fix(cli): add shebang for kill-children.sh Jun 21, 2022
@brian14708 brian14708 marked this pull request as ready for review June 21, 2022 11:00
@brian14708 brian14708 requested a review from a team June 21, 2022 11:00
@brian14708 brian14708 requested a review from a team as a code owner June 21, 2022 11:00
@lucasfernog lucasfernog linked an issue Jun 21, 2022 that may be closed by this pull request
@lucasfernog lucasfernog changed the title fix(cli): add shebang for kill-children.sh fix(cli): add shebang for kill-children.sh, closes #4262 Jun 21, 2022
@lucasfernog
Copy link
Member

Thanks for catching this!

@lucasfernog lucasfernog merged commit 35dd51d into tauri-apps:dev Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] Development Server Do Not Killed After Window Exited

2 participants