fix(bundler): ensure AppImage usr/lib is a dir#4419
Merged
lucasfernog merged 2 commits intotauri-apps:devfrom Jun 21, 2022
Merged
fix(bundler): ensure AppImage usr/lib is a dir#4419lucasfernog merged 2 commits intotauri-apps:devfrom
lucasfernog merged 2 commits intotauri-apps:devfrom
Conversation
Possibly the usr/lib directory wasn't yet created before copying the designated tray library. Resulting in a usr/lib _file_ containing libappindicator3.so and following commands failing as it expected a directory.
lucasfernog
approved these changes
Jun 21, 2022
Member
|
Would be amazing if you could setup commit signing for the next PR @Beanow thanks for the PR ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
Possibly the usr/lib directory wasn't yet created before copying the designated tray library. Resulting in a usr/lib file containing libappindicator3.so and following commands failing as it expected a directory.
Reproducing
{ "tauri": { "systemTray": { "iconPath": "icons/icon.png", "iconAsTemplate": true } } }yarn tauri --verbose build.The bundler will cause errors like:

cp: './usr/lib' exists but is not a directoryAnd the AppDir contains a file usr/lib containing libappindicator3.so.
Appimage bundling log