Fix appimage creation in container when host has appimagelauncher enabled#4457
Fix appimage creation in container when host has appimagelauncher enabled#4457lucasfernog merged 2 commits intotauri-apps:devfrom dswd:patch-1
Conversation
Fix appimage creation in container when host has appimagelauncher enabled
|
I tried running appimagelauncherd and the logs shows |
|
@lucasfernog For me it behaves as described by the OP. Without the change appimagelauncher thinks it's an appimage, and with their branch it doesn't, without any side-effects for me (= the build succeeds). |
|
A weird side effect is that I had to reboot after uninstalling appimagelauncher, it was giving me the same |
I ran into a problem that building the very same project in the very same container worked on one machine but not on the other (same host OS, roughly same version). The error was
./linuxdeploy-x86_64.AppImage: No such file or directory. As I looked into the problem I found this:If Appimagelauncher is enabled on the host, it modifies binfmt to inject itself as a launcher for appimages. This also applies to appimages in containers although the appimagelauncher binary is most likely not available there. So the "No such file" does not mean the appimage itself but the launcher it tries to execute.
The easiest way to fix this is to modify the appimage ELF header so that binfmt no longer identifies it as an appimage and lets the binary run itself. This is my PR.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information