Skip to content

fix: fire window-specific event on Window emit_to/emit_all, closes #4493#4498

Merged
lucasfernog merged 1 commit intodevfrom
fix/window-emit
Jun 28, 2022
Merged

fix: fire window-specific event on Window emit_to/emit_all, closes #4493#4498
lucasfernog merged 1 commit intodevfrom
fix/window-emit

Conversation

@lucasfernog
Copy link
Member

@lucasfernog lucasfernog commented Jun 28, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team as a code owner June 28, 2022 04:01
@lucasfernog lucasfernog merged commit 643ae84 into dev Jun 28, 2022
@lucasfernog lucasfernog deleted the fix/window-emit branch June 28, 2022 12:34
amrbashir
amrbashir reviewed Jun 28, 2022
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amrbashir amrbashir amrbashir left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lucasfernog @amrbashir