Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(updater): fallback if tmp is on different mount point, closes #4500 #4504

Merged
merged 2 commits into from
Jun 28, 2022

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team as a code owner June 28, 2022 14:07
@lucasfernog
Copy link
Member Author

I also removed the #[cfg(feature = "updater")]in the core.rs file since we do not have an specific feature for updater documentation generation anymore (we previously had one because the updater feature enabled the zip crate, which didn't cross compile for docs.rs - now fixed by removing its default features).

@Beanow
Copy link
Member

Beanow commented Jun 28, 2022

I'll leave the call up to a maintainer, but my thoughts are addressed 👌

@lucasfernog
Copy link
Member Author

Thanks for the review @Beanow

@lucasfernog lucasfernog merged commit fd125f7 into dev Jun 28, 2022
@lucasfernog lucasfernog deleted the fix/linux-updater branch June 28, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants