Skip to content

Conversation

@Beanow
Copy link
Member

@Beanow Beanow commented Jun 28, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

AppImage bundling will now prefer bundling correctly named appincidator library (including .1 version suffix). With a symlink for compatibility with the old naming.

I've done a fair bit of testing on how this interacts with tauri-apps/libappindicator-rs#38
Detailed result at this comment tauri-apps/libappindicator-rs#38 (comment)

TL;DR this PR and the libappindicator-sys can be released and upgraded independently without breaking the tray feature.

AppImage bundling will now prefer bundling correctly named appincidator library (including `.1` version suffix). With a symlink for compatibility with the old naming.
@Beanow Beanow requested a review from a team as a code owner June 28, 2022 14:09
@lucasfernog lucasfernog merged commit bf45ca1 into tauri-apps:dev Jun 29, 2022
@Beanow Beanow deleted the fix/libnames branch June 29, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants