Skip to content

fix(cli): Don't add pkg-config to deb#4508

Merged
lucasfernog merged 2 commits intotauri-apps:devfrom
Beanow:break/deb-rm-pkg-config
Jun 29, 2022
Merged

fix(cli): Don't add pkg-config to deb#4508
lucasfernog merged 2 commits intotauri-apps:devfrom
Beanow:break/deb-rm-pkg-config

Conversation

@Beanow
Copy link
Member

@Beanow Beanow commented Jun 28, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

⚠️ tauri-apps/libappindicator-rs#38 needs to be published ⚠️

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

No longer adds the pkg-config dependency to .deb packages when the systemTray is used. This only works with recent versions of libappindicator-sys (including tauri-apps/libappindicator-rs#38), so a cargo update may be necessary if you create .deb bundles and use the tray feature.

Beanow added 2 commits June 28, 2022 19:57
No longer adds the `pkg-config` dependency to `.deb` packages when the `systemTray` is used. This only works with recent versions of `libappindicator-sys` (including tauri-apps/libappindicator-rs#38), so a `cargo update` may be necessary if you create `.deb` bundles and use the tray feature.
@Beanow Beanow requested a review from a team as a code owner June 28, 2022 18:02
@lucasfernog lucasfernog merged commit 0e6edeb into tauri-apps:dev Jun 29, 2022
@Beanow Beanow deleted the break/deb-rm-pkg-config branch June 29, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants