fix(bundler): Build AppImages inside the target folder #4521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously to avoid an issue with AppImage builds we collected all our output files in ~/.cache. This solves the reason why we did that and moves back to putting our temporary files in the target folder again.
|
Works like a charm. Why is this a draft @Beanow ? |
|
Still needs a change entry, and I was thinking if more refactors should be included. Like, asserting the file ends up in the right place now to avoid regressions. As is it should work though. |
Beanow
commented
Jul 1, 2022
| chmod +x linuxdeploy-plugin-gtk.sh | ||
| chmod +x linuxdeploy-${ARCH}.AppImage | ||
| chmod +x "{{tauri_tools_path}}/linuxdeploy-plugin-gtk.sh" | ||
| chmod +x "{{tauri_tools_path}}/linuxdeploy-${ARCH}.AppImage" | ||
|
|
||
| dd if=/dev/zero bs=1 count=3 seek=8 conv=notrunc of=linuxdeploy-${ARCH}.AppImage |
There was a problem hiding this comment.
Ah, see this one I missed.
There was a problem hiding this comment.
Patched this and set it as ready for review
lucasfernog
approved these changes
Jul 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
Previously to avoid an issue with AppImage builds we collected all our output files in
~/.cache. This solves the reason why we did that and moves back to putting our temporary files in thetargetfolder again.The main problem at that time was, #4305 introduced a change where build tools should be stored in
~/.cache/tauri.However one particular file that we download,
AppRun, was supposed to be bundled, instead of executed as a build tool.The path where it needed to be was in
{{app_name}}.AppDir/AppRun.I've fixed it here by still downloading all dependencies to
~/.cache/tauri, but also making a copy ofAppRunin the correct place. Allowing builds intargetto work again.As an aside, building in
targetis preferable because we don't use a conflict-free unique or fully qualified name when building AppImages, so race conditions might happen when building multiple projects.Also, "cleaning target" is an easy way to remove your project specific caches and intermediate builds, to get a clean slate. Which wouldn't apply for AppImages as they're not always in
target.