Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli.rs): conflicts_with arg doesn't exist closes #4538

Merged
merged 2 commits into from
Jun 30, 2022

Conversation

JonasKruckenberg
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

If you run the command cargo run -- signer sign --help using the latest master commit it will panick with the following message:

$ cargo run -- signer sign --help
   Compiling tauri-cli v1.0.1 (/Users/jonaskruckenberg/Documents/GitHub/tauri/tooling/cli)
    Finished dev [unoptimized + debuginfo] target(s) in 6.01s
     Running `target/debug/cargo-tauri signer sign --help`
thread 'main' panicked at 'Command sign: Argument or group 'private_key_path' specified in 'conflicts_with*' for 'private-key' does not exist', /Users/jonaskruckenberg/.cargo/registry/src/github.com-1ecc6299db9ec823/clap-3.2.7/src/builder/debug_asserts.rs:237:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

This PR adds a quick fix for this (cherry picked from #4537)

@JonasKruckenberg JonasKruckenberg requested a review from a team as a code owner June 30, 2022 12:11
@lucasfernog lucasfernog merged commit 8e808fe into dev Jun 30, 2022
@lucasfernog lucasfernog deleted the fix-conflictswith-arg branch June 30, 2022 13:39
lucasfernog added a commit that referenced this pull request May 25, 2023
lucasfernog added a commit that referenced this pull request May 25, 2023
This reverts commit 211269c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants