Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bundler): enable TLS 1.2 before downloading webview2 bootstrapper #4543

Merged
merged 3 commits into from
Jun 30, 2022

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team as a code owner June 30, 2022 17:32
@lucasfernog
Copy link
Member Author

This PR changes our WiX powershell script that downloads and runs the Webview2 Bootstrapper to try enabling TLS 1.2 for the current powershell session following the official documentation. We add a try/catch around it because in Windows 7 the Tls12 enum variant might not exist.

@lucasfernog lucasfernog merged commit 3df6c8c into dev Jun 30, 2022
@lucasfernog lucasfernog deleted the feat/download-bootstrapper-enhancement branch June 30, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant