Skip to content

feat: add implicit default menu for macOS only, closes #4551#4570

Merged
lucasfernog merged 5 commits intodevfrom
macos-only-default-menu
Jul 3, 2022
Merged

feat: add implicit default menu for macOS only, closes #4551#4570
lucasfernog merged 5 commits intodevfrom
macos-only-default-menu

Conversation

@amrbashir
Copy link
Member

@amrbashir amrbashir commented Jul 2, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog merged commit 9105588 into dev Jul 3, 2022
@lucasfernog lucasfernog deleted the macos-only-default-menu branch July 3, 2022 23:26
@flappyBug
Copy link

flappyBug commented Dec 3, 2022

It looks like enable_macos_default_menu cannot be set to false. Neither by construction nor by mutation. There is no way to disable menu for macOS.

@amrbashir
Copy link
Member Author

@flappyBug thanks for reporting that, I will open a PR shortly.

@amrbashir
Copy link
Member Author

here it is #5756

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants