fix(updater): do not run in dialog mode on .deb, closes #4573#4577
Merged
lucasfernog merged 1 commit intodevfrom Jul 5, 2022
Merged
fix(updater): do not run in dialog mode on .deb, closes #4573#4577lucasfernog merged 1 commit intodevfrom
lucasfernog merged 1 commit intodevfrom
Conversation
Contributor
|
Didn't know you went ahead with this, so did some duplicate work, see betamos@0569eb7 Anyway, I also added a dev mode check to error out if installation is attempted, which we might wanna have to prevent touching files. I can remove the appimage check and send a PR for that part only, perhaps? |
Member
Author
|
@betamos I think disabling it on dev makes it harder to develop a custom updater flow, even though the installation will likely fail. We could document it instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information