Skip to content

fix(updater): do not run in dialog mode on .deb, closes #4573#4577

Merged
lucasfernog merged 1 commit intodevfrom
fix/updater-dialog
Jul 5, 2022
Merged

fix(updater): do not run in dialog mode on .deb, closes #4573#4577
lucasfernog merged 1 commit intodevfrom
fix/updater-dialog

Conversation

@lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team as a code owner July 3, 2022 22:48
@betamos
Copy link
Contributor

betamos commented Jul 4, 2022

Didn't know you went ahead with this, so did some duplicate work, see betamos@0569eb7

Anyway, I also added a dev mode check to error out if installation is attempted, which we might wanna have to prevent touching files. I can remove the appimage check and send a PR for that part only, perhaps?

@lucasfernog
Copy link
Member Author

@betamos I think disabling it on dev makes it harder to develop a custom updater flow, even though the installation will likely fail. We could document it instead.

@lucasfernog lucasfernog merged commit e29fff2 into dev Jul 5, 2022
@lucasfernog lucasfernog deleted the fix/updater-dialog branch July 5, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants