refactor: do not pass entire config from CLI to core, send patch instead#4598
refactor: do not pass entire config from CLI to core, send patch instead#4598lucasfernog merged 1 commit intodevfrom
Conversation
|
This PR changes the TAURI_CONFIG environment variable to represent the config JSON from the CLI's |
|
tbh i expected this to break something but everything i tested (same version,cli newer, cli older) worked lol, except of course if you add conf properties one side doesn't know of. Because of that we mayyy wanna consider improving the tauri-build panic message in the future, because this: [...]
--- stderr
thread 'main' panicked at 'error found during tauri-build: Error("unknown field `kekw`, expected `bundleMediaFramework`", line: 0, column: 0)', C:\Users\Fabian-Lars\dev\tauri\core\tauri-build\src\lib.rs:172:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
Error failed to build app: failed to build appnot only scares non-rust users but nobody really understands/knows that this means that they need to update their crates. |
|
I'll adjust the error message in a separate PR. |
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information