Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bundler): use known Id for the sidecar files on WiX, ref #4546 #4658

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

This PR changes the WiX file Id for sidecars to be a known string instead of a randomly generated one. This allows users to reference the sidecar in their WiX fragments for e.g. adding firewall rules for it.

@lucasfernog lucasfernog requested a review from a team as a code owner July 12, 2022 17:37
@lucasfernog lucasfernog merged commit 597c982 into dev Jul 12, 2022
@lucasfernog lucasfernog deleted the feat/wix-sidecar-ids branch July 12, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant