feat(bundler): add nsis, closes #4450, closes #2319 #4674
Merged
lucasfernog merged 50 commits intodevfrom Jan 3, 2023
Merged
Conversation
1 task
Closed
Member
|
You made it look easy @amrbashir let me know if I did something wrong. Let's merge this tomorrow ❤️ |
Member
Author
|
There are two features I was hoping to address before merge:
I will see if I can finish them tomorrow, if not, I can add them later in another PR. |
Member
|
We can add it later too no problem. |
Member
Author
|
Sure go ahead and merge if you want, I will add the missing features laeter. |
lucasfernog
reviewed
Dec 16, 2022
Member
Author
|
took me a lot of trials and errors and workarounds but |
FabianLars
reviewed
Dec 22, 2022
Co-authored-by: Fabian-Lars <fabianlars@fabianlars.de>
lucasfernog
approved these changes
Jan 3, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
TODOs: