feat(core): add option to use vendored openssl, closes #4470#4809
Merged
lucasfernog merged 3 commits intodevfrom Aug 2, 2022
Merged
feat(core): add option to use vendored openssl, closes #4470#4809lucasfernog merged 3 commits intodevfrom
lucasfernog merged 3 commits intodevfrom
Conversation
Member
|
Something doesn't feel right. By disabling the default features you're basically disabling TLS altogether, right? (at least if the vendored flag is disabled? i don't know, reqwest's feature flags are so weird i can't get my head around that) |
Member
Author
|
You're right @FabianLars thanks for catching that. I was going to make the features exclusive but that doesn't work without some 1.60 features, and I forgot to remove that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information