Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add option to use vendored openssl, closes #4470 #4809

Merged
merged 3 commits into from
Aug 2, 2022

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team as a code owner July 31, 2022 21:15
@FabianLars
Copy link
Member

Something doesn't feel right. By disabling the default features you're basically disabling TLS altogether, right? (at least if the vendored flag is disabled? i don't know, reqwest's feature flags are so weird i can't get my head around that)

@lucasfernog
Copy link
Member Author

You're right @FabianLars thanks for catching that. I was going to make the features exclusive but that doesn't work without some 1.60 features, and I forgot to remove that.

@lucasfernog lucasfernog merged commit 331f346 into dev Aug 2, 2022
@lucasfernog lucasfernog deleted the feat/vendored-openssl branch August 2, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants