Skip to content

feat(tauri-build): validate sidecar name, closes #4780 closes #4823 - #4814

Merged
lucasfernog merged 1 commit into
devfrom
feat/validate-sidecar-name
Aug 2, 2022
Merged

feat(tauri-build): validate sidecar name, closes #4780 closes #4823#4814
lucasfernog merged 1 commit into
devfrom
feat/validate-sidecar-name

Conversation

@lucasfernog

Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog
lucasfernog requested a review from a team as a code owner August 1, 2022 00:03
@lucasfernog lucasfernog linked an issue Aug 2, 2022 that may be closed by this pull request
@lucasfernog lucasfernog changed the title feat(tauri-build): validate sidecar name, closes #4780 feat(tauri-build): validate sidecar name, closes #4780 closes #4823 Aug 2, 2022
@lucasfernog
lucasfernog merged commit 5cc1fd0 into dev Aug 2, 2022
@lucasfernog
lucasfernog deleted the feat/validate-sidecar-name branch August 2, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New window created on each trigger of sidecar

1 participant